fix(cli): terminal detection for WezTerm/Ghostty/Warp/Konsole + Windo… - #1083
Open
smarpitm wants to merge 1 commit into
Open
fix(cli): terminal detection for WezTerm/Ghostty/Warp/Konsole + Windo…#1083smarpitm wants to merge 1 commit into
smarpitm wants to merge 1 commit into
Conversation
…ws pwsh fallback Add kitty graphics protocol detection for WezTerm, Ghostty, Warp, and Konsole terminals (case-insensitive TERM_PROGRAM matching + KONSOLE_VERSION). Fix Windows clipboard image paste failing silently when powershell.exe is missing by falling back to pwsh (PowerShell 7). Normalize stdout/stderr to strings so callers don't handle the string | Buffer union. Also includes spec-compliant kitty chunking (m=0 terminator on last chunk, control data only on first chunk), iTerm2 size param fix (decoded bytes not base64 length), and image pipeline integrity tests. Split from a912ea6 — the getKittyFormat() format ID fix is deferred to a follow-up PR. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
|
Good work here — several of these are genuine, well-reasoned bug fixes rather than cosmetic churn:
My main critique is scope: this bundles three fairly independent changes (protocol chunking fix, terminal detection, Windows shell fallback) into one PR. Splitting the clipboard/pwsh piece out with its own test would make it easier to port and verify in isolation. The Overall the core protocol fixes are worth taking; the Windows fallback piece would benefit from a test before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ws pwsh fallback
Add kitty graphics protocol detection for WezTerm, Ghostty, Warp, and Konsole terminals (case-insensitive TERM_PROGRAM matching + KONSOLE_VERSION).
Fix Windows clipboard image paste failing silently when powershell.exe is missing by falling back to pwsh (PowerShell 7). Normalize stdout/stderr to strings so callers don't handle the string | Buffer union.
Also includes spec-compliant kitty chunking (m=0 terminator on last chunk, control data only on first chunk), iTerm2 size param fix (decoded bytes not base64 length), and image pipeline integrity tests.
Split from a912ea6 — the getKittyFormat() format ID fix is deferred to a follow-up PR.
🤖 Generated with Codebuff